Change in osmo-ci[master]: lint: enable FUNCTION_WITHOUT_ARGS

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30003 ) Change subject: lint: enable FUNCTION_WITHOUT_ARGS ...................................................................... lint: enable FUNCTION_WITHOUT_ARGS Complain if one writes func() instead of func(void). Change-Id: Ic00041025ac2584f250b5a096eae8fd0d857d9fb --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 7a60ad6..bc45f85 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -61,7 +61,6 @@ # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/ # * FILE_PATH_CHANGES: we don't use a MAINTAINERS file -# * FUNCTION_WITHOUT_ARGS: not followed: warns about func() instead of func(void) # * GLOBAL_INITIALISERS: we initialise globals to NULL for talloc ctx (e.g. *tall_lapd_ctx = NULL) # * IF_0: used intentionally # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html @@ -100,7 +99,6 @@ --ignore EMBEDDED_FUNCTION_NAME \ --ignore EXECUTE_PERMISSIONS \ --ignore FILE_PATH_CHANGES \ - --ignore FUNCTION_WITHOUT_ARGS \ --ignore GLOBAL_INITIALISERS \ --ignore IF_0 \ --ignore INITIALISED_STATIC \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic00041025ac2584f250b5a096eae8fd0d857d9fb Gerrit-Change-Number: 30003 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged