[L] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 6: (2 comments) Patchset: PS2: Done. I added a unit test and also developed a TTCN-3 testcase. Patchset: PS4: I ended up extending the idea and reworking the patch significantly: * `s1ap_proxy:proc` (former `s1ap_proxy:handle_pdu`) now returns a forwarding action: * `{forward, binary()}` -- forward to the other peer, * `{reply, binary()}` -- reply to the sending peer. * I don't see a use case for forwarding something and replying to the sending peer at the same time, so this is no longer possible. We can re-introduce this if needed in form of `[{forward, binary()}, {reply, binary()}]`, but for now let's avoid additional complexity without the need for such functionality. * `handle_pdu/3` becomes `handle_pdu/2` and does not accept the raw binary anymore, it can simply return `forward` alone to indicate the the binary blob should be forwarded as-is (handled in `proc/2`). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Sep 2024 07:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>