Attention is currently required from: laforge, lynxis lazus, pespin.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    So what is the status here? Why do we have no unit nor functional/integration tests for this patch? […]

    Done. I added a unit test and also developed a TTCN-3 testcase.

• Patchset:

  • Patch Set #4:

    Please do whatever you deem necessary so it can finally get merged.

    I ended up extending the idea and reworking the patch significantly:

    * `s1ap_proxy:proc` (former `s1ap_proxy:handle_pdu`) now returns a forwarding action:
     * `{forward, binary()}` -- forward to the other peer,
     * `{reply, binary()}` -- reply to the sending peer.
    * I don't see a use case for forwarding something and replying to the sending peer at the same time, so this is no longer possible. We can re-introduce this if needed in form of `[{forward, binary()}, {reply, binary()}]`, but for now let's avoid additional complexity without the need for such functionality.
    * `handle_pdu/3` becomes `handle_pdu/2` and does not accept the raw binary anymore, it can simply return `forward` alone to indicate the the binary blob should be forwarded as-is (handled in `proc/2`).

To view, visit change 37924. To unsubscribe, or for help writing mail filters, visit settings.