Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email )
Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ......................................................................
Patch Set 1:
(3 comments)
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/8e40abe4_ece65fd8?... : PS1, Line 494: OSMO_ASSERT(cli);
If you dive into the code you'd like to put even more asserts! […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/653f7f9f_0f0e862f?... : PS1, Line 545: osmo_stream_cli_send
because osmo_stream_cli_send() returns void. […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/89e44a92_c1c4486d?... : PS1, Line 992: err: : return -1;
Yes, but I prefer having all error paths easily visible this way.
Done