Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/29905
)
Change subject: Delay ImmAss(PCH, PktDlAss) if waiting for PKT_CTRL_ACK answering
UL_ACK_NACK (FinACK=1)
......................................................................
Patch Set 2:
(2 comments)
File src/pdch.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/29905/comment/a6db0106_8188edd5
PS2, Line 388: something is wrong
should it log an error message in both if code paths
then?
The logging in he correct path is done through usual FSM event logging.
The previous log also was moved inside the FSM.
This way the log shows first the event being sent and later the consequence of the event
(the UPLINK TBF ending).
File src/tbf_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29905/comment/7da40346_33febd03
PS2, Line 265: thr
the
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/29905
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a30db9cc7dae70e04054f1a4dba004bd1780d4a
Gerrit-Change-Number: 29905
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Oct 2022 13:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment