[L] Change in pysim[master]: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing

Attention is currently required from: dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email ) Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: For "distcheck" we run "pip install .", see contrib/jenkins.sh. I've reproduced it locally, and fixed it like this: ```diff diff --git a/requirements.txt b/requirements.txt index ec04b6e..4e094b2 100644 --- a/requirements.txt +++ b/requirements.txt @@ -14,4 +14,4 @@ cryptography git+https://github.com/osmocom/asn1tools packaging git+https://github.com/hologram-io/smpp.pdu -git+https://github.com/jookies/smpp.twisted +smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted diff --git a/setup.py b/setup.py index e9ffd97..2cd0e8f 100644 --- a/setup.py +++ b/setup.py @@ -31,7 +31,7 @@ setup( "pycryptodomex", "packaging", "smpp.pdu @ git+https://github.com/hologram-io/smpp.pdu"quot;, - "smpp.twisted @ git+https://github.com/jookies/smpp.twisted"quot;, + "smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted"quot;, ], scripts=[ 'pySim-prog.py', ``` NOTE: I would suggest referencing a specific commit instead of current master, otherwise it may break at some point in a non-obvious way. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie5bae9d823bca6f6c658bd455303f63bace2258c Gerrit-Change-Number: 37456 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jul 2024 09:50:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment