Attention is currently required from: dexter, laforge.

View Change

1 comment:

• Patchset:

  • Patch Set #3:

    strange enough, I can manually install the package using "pip install git+https://github. […]

    For "distcheck" we run "pip install .", see contrib/jenkins.sh.

    I've reproduced it locally, and fixed it like this:

    ```diff
    diff --git a/requirements.txt b/requirements.txt
    index ec04b6e..4e094b2 100644
    --- a/requirements.txt
    +++ b/requirements.txt
    @@ -14,4 +14,4 @@ cryptography
     git+https://github.com/osmocom/asn1tools
     packaging
     git+https://github.com/hologram-io/smpp.pdu
    -git+https://github.com/jookies/smpp.twisted
    +smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted
    diff --git a/setup.py b/setup.py
    index e9ffd97..2cd0e8f 100644
    --- a/setup.py
    +++ b/setup.py
    @@ -31,7 +31,7 @@ setup(
             "pycryptodomex",
             "packaging",
             "smpp.pdu @ git+https://github.com/hologram-io/smpp.pdu",
    -        "smpp.twisted @ git+https://github.com/jookies/smpp.twisted",
    +        "smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted",
         ],
         scripts=[
             'pySim-prog.py',

    ```

    NOTE: I would suggest referencing a specific commit instead of current master, otherwise it may break at some point in a non-obvious way.

To view, visit change 37456. To unsubscribe, or for help writing mail filters, visit settings.