Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )
Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
@lynxis@fe80. […]
I don't see a good
solution for it.
So far I know, there isn't a good way to modify a single change-set without changing
all commits in the same chain.
If I don't push my review-branch all at once, I might overwrite reworked commits later
in the chain.
I also fixed problems in here, the missing include in Makefile.am, which seems to be not a
problem, when you have "old" files around. It builds as long you don't treat
the strncpy as errors.
About this commit:
It only synchronizes against a osmo-msc commit.
I don't want to modify any code of the libvlr code, otherwise you can't track
improvements between both branches.
I consider osmo-msc as "upstream" as long libvlr isn't self-container.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d
Gerrit-Change-Number: 39560
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 22 Feb 2025 14:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>