Attention is currently required from: dexter, laforge, neels, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168?usp=email )
Change subject: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes during MDCX ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/2de55e9a_a309f8f0 PS1, Line 299: /* Forward the RAB-AssignmentResponse transparently. This will ensure that the MSC is informed
cosmetic: now that there's more indentation, I'd wrap the comment lines so it doesn't go wider than […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/f540b9bf_44a2c0f9 PS1, Line 327: if (mgw_fsm_priv->mdcx_tx_cnt > 3) {
log an error here?
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168/comment/d1effed6_dadcad02 PS1, Line 414: LOGL_ERROR
Sounds like this is now expected behavior and not an error -> change the log level?
Done