Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 )
Change subject: gsm_objclass2obj(): Change signature so we can obtain a nack cause in case of error ......................................................................
Patch Set 1:
(2 comments)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/9c46adb3_957f77e3 PS1, Line 1799: gsm_objclass2obj(enum abis_nm_nack_cause *c, struct gsm_bts *bts, uint8_t obj_class,
same here, this should be at the end and be able to pass NULL to it.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/072b13d5_49b3ede2 PS1, Line 1804: /* Handle finding TRX number first */
Same here, please don't move this into a new switch.
Done