Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460?usp=email )
Change subject: sctp_proxy: handle_pdu/2: print stacktrace on exception
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460/comment/e4be5703_931b…
PS1, Line 208: ?LOG_ERROR("An exception occurred: ~p, ~p, ~p",
[Exception, Reason, StackTrace]),
I think it may make sense to print Data too in here.
It's already being printed by the calling functions (e.g. in
`src/sctp_proxy.erl:164`), so I am not sure if it makes sense to print it again here. Can
be done in a separate patch when I am convinced.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7fef18d4462af4b629318922e59cb5aa161fed93
Gerrit-Change-Number: 37460
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 14 Jul 2024 10:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment