Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460?usp=email )
Change subject: sctp_proxy: handle_pdu/2: print stacktrace on exception ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460/comment/e4be5703_931b2... PS1, Line 208: ?LOG_ERROR("An exception occurred: ~p, ~p, ~p", [Exception, Reason, StackTrace]),
I think it may make sense to print Data too in here.
It's already being printed by the calling functions (e.g. in `src/sctp_proxy.erl:164`), so I am not sure if it makes sense to print it again here. Can be done in a separate patch when I am convinced.