Attention is currently required from: pespin.
Patch set 1:Code-Review +2
View Change
1 comment:
File src/sctp_proxy.erl:
Patch Set #1, Line 208: ?LOG_ERROR("An exception occurred: ~p, ~p, ~p", [Exception, Reason, StackTrace]),
I think it may make sense to print Data too in here.
It's already being printed by the calling functions (e.g. in `src/sctp_proxy.erl:164`), so I am not sure if it makes sense to print it again here. Can be done in a separate patch when I am convinced.
To view, visit change 37460. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7fef18d4462af4b629318922e59cb5aa161fed93
Gerrit-Change-Number: 37460
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Sun, 14 Jul 2024 10:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment