Attention is currently required from: laforge.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/39623?usp=email )
Change subject: rtp2trau HR: remove broken TRAU-16k-UL support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not really a big fan of removing code rather
than fixing it. […]
Since you originally wrote this TRAU<->RTP code in 2020
and since you chose back then to implement HR support in TRAU-16k format instead of
TRAU-8k, let me ask you: do you know of any historical E1 BTS model(s) that implement HR
speech (or data) in TRAU-16k format? My admittedly naive understanding is that E1 BTS
traditionally allocate one 16 kbit/s subslot for each GSM timeslot, thus when a GSM ts is
configured for TCH/H, only 8 kbit/s is available for each lchan. Or does it work
differently in some vendor implementations?
I am open to idea of fixing TRAU-16k-UL output code instead of removing it *if* I can see
captures of Abis UL output from some historical BTS that implements this format. In that
case I would first extend my ThemWi TRAU frame parsing tools to decode that format, verify
that the test tool matches what the historical BTS put out, then fix the code in
libosmotrau and unit-test it against the ThemWi decoding tool that was in turn verified
against historical hw.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39623?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: If50036c4de9a11db524abffcd87d053878104982
Gerrit-Change-Number: 39623
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 27 Feb 2025 13:07:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>