laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30449 )
Change subject: Initialize devinfo at misdn.c
......................................................................
Initialize devinfo at misdn.c
Valgrind did complain about use of uninitialized data.
Change-Id: I3a60eee96366561acac9ccfc92eb0d6ca828b7b9
---
M src/input/misdn.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/input/misdn.c b/src/input/misdn.c
index 5d47a79..0925cbf 100644
--- a/src/input/misdn.c
+++ b/src/input/misdn.c
@@ -822,6 +822,7 @@
//LOGPIL(line, DLMI, LOGL_DEBUG, "%d device%s found\n", cnt,
(cnt==1)?"":"s");
printf("%d device%s found\n", cnt, (cnt==1)?"":"s");
#if 1
+ memset(&devinfo, 0, sizeof(devinfo));
devinfo.id = line->port_nr;
ret = ioctl(sk, IMGETDEVINFO, &devinfo);
if (ret < 0) {
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30449
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3a60eee96366561acac9ccfc92eb0d6ca828b7b9
Gerrit-Change-Number: 30449
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged