Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721?usp=email )
Change subject: 7816 fsm: drop inverse convention lut for arm ......................................................................
Patch Set 1:
(4 comments)
File ccid_common/iso7816_fsm.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/c99fefe9_27b... : PS1, Line 153: #define invert_flip_uint8(XX) \ do {} while (0) macros should not be semicolon terminated
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/f589fec6_3dc... : PS1, Line 159: __asm__ volatile("rbit %0, %0 \n\t" \ unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/168a5400_ba9... : PS1, Line 160: "uxtb.w %0, %0, ror #24 \n\t" \ unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/40721/comment/234b7939_b4c... : PS1, Line 184: #define invert_flip_uint8(XX) \ do {} while (0) macros should not be semicolon terminated