laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39014?usp=email )
Change subject: gprs_ns2_sns: move the NS-ALIVE PDU of a new NS-VC after the SNS-ACK ......................................................................
gprs_ns2_sns: move the NS-ALIVE PDU of a new NS-VC after the SNS-ACK
When adding a new NS-VC after the SNS-CONFIG is done, the new NS-VC would send out a NS-ALIVE before sending out the SNS-ACK towards the remote NSE. This isn't a big issue, because the SNS-ACK can be reordered by the network anyways, but be nice and ensure the order matches the expectation.
Related: OS#6611 Change-Id: I6503bbb32b4440eb53f8c9bd03572f4a189f1a86 --- M src/gb/gprs_ns2_sns.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index de0400f..6b92370 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -792,8 +792,6 @@ break; }
- gprs_ns2_start_alive_all_nsvcs(nse); - return 0; }
@@ -1267,6 +1265,8 @@
/* TODO: correct behaviour is to answer to the *same* NSVC from which the SNS_ADD was received */ ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, v4_list, num_v4, v6_list, num_v6); + + gprs_ns2_start_alive_all_nsvcs(gss->nse); }
static void ns2_sns_st_configured_delete(struct osmo_fsm_inst *fi,