Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email )
Change subject: SMS over GSUP: implement forwarding of MO SMS ......................................................................
Patch Set 2:
(1 comment)
File src/hlr_sms.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/34449/comment/694257e1_3a07a495 PS2, Line 136: char smsc_addr[21];
libsmpp34/src/smpp34_structs.h […]
Adding libsmpp34 as a mandatory dependency for osmo-hlr is a horrible idea. As it currently stands, libsmpp34 is an optional dependency for osmo-msc (enabled by a configure option, disabled by default) and does not constitute a mandatory dependency for any CNI component, let alone HLR which fundamentally has nothing to do with SMS.
My current thought is to make a patch to libosmocore adding GSM 04.11 section 8.2.5.1 and 8.2.5.2 definitions to <osmocom/gsm/protocol/gsm_04_11.h> - let's see how it goes.