[M] Change in osmo-hlr[master]: SMS over GSUP: implement forwarding of MO SMS

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email ) Change subject: SMS over GSUP: implement forwarding of MO SMS ...................................................................... Patch Set 2: (1 comment) File src/hlr_sms.c: https://gerrit.osmocom.org/c/osmo-hlr/+/34449/comment/694257e1_3a07a495 PS2, Line 136: char smsc_addr[21]; Adding libsmpp34 as a mandatory dependency for osmo-hlr is a horrible idea. As it currently stands, libsmpp34 is an optional dependency for osmo-msc (enabled by a configure option, disabled by default) and does not constitute a mandatory dependency for any CNI component, let alone HLR which fundamentally has nothing to do with SMS. My current thought is to make a patch to libosmocore adding GSM 04.11 section 8.2.5.1 and 8.2.5.2 definitions to <osmocom/gsm/protocol/gsm_04_11.h> - let's see how it goes. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iaad4531922c41583d261c79f42561a1bdbe03521 Gerrit-Change-Number: 34449 Gerrit-PatchSet: 2 Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 18 Sep 2023 18:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment