Attention is currently required from: laforge, pespin, fixeria, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 )
Change subject: pcu_l1_if_phy: flexible phy access ......................................................................
Patch Set 11:
(7 comments)
Patchset:
PS11: i have some more nitpicks, hope you're reading them in a good tone =)
File src/pcu_l1_if_phy.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/7f96941e_2c445138 PS11, Line 20: obj please clarify void* obj.
Please provide detailed API doc about each of the callbacks, describing what they should do and what each parameter means.
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/48e19362_a3671b7d PS11, Line 26: confg typo
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/b96ca746_efbc4aa3 PS11, Line 27: * initialization functions. The callback may be set to NULL in case no initialization is needed. */ (in general API doc is shorter and clearer in the imperative form:
Initialize PHY. May be NULL to skip. For example: add VTY config options, call library initialization.
)
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/ae7b2b03_50e6e0e6 PS11, Line 28: ctx is ctx the same as obj above? please add API doc for it
File src/pcu_l1_if_phy.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/d6b5bdfe_9e57f45e PS11, Line 94: comment above which comment?
https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/41891725_55b73a45 PS11, Line 94: spcified typo "spcified"
I guess the entire comment should be "Activate PHY." followed by description of params