Attention is currently required from: laforge, pespin, fixeria, dexter.

7 comments:

Patchset:
- Patch Set #11:
  i have some more nitpicks, hope you're reading them in a good tone =)
File src/pcu_l1_if_phy.h:
- Patch Set #11, Line 20: obj
  please clarify void* obj.
  Please provide detailed API doc about each of the callbacks, describing what they should do and what each parameter means.
- Patch Set #11, Line 26: confg
  typo
- Patch Set #11, Line 27: * initialization functions. The callback may be set to NULL in case no initialization is needed. */
  (in general API doc is shorter and clearer in the imperative form:
```
 Initialize PHY. May be NULL to skip.
 For example: add VTY config options, call library initialization.
 
)
```
- Patch Set #11, Line 28: ctx
  is ctx the same as obj above? please add API doc for it
File src/pcu_l1_if_phy.c:
- Patch Set #11, Line 94: comment above
  which comment?
- Patch Set #11, Line 94: spcified
  typo "spcified"
  I guess the entire comment should be "Activate PHY." followed by description of params

To view, visit change 31341. To unsubscribe, or for help writing mail filters, visit settings.