Attention is currently required from: dexter, fixeria, pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email )
Change subject: TCH UL path: add out-of-band BFI flag
......................................................................
Patch Set 2:
(3 comments)
File include/osmo-bts/msg_utils.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/b9a2ef54_06bd1b62?usp… :
PS1, Line 27: /* Accessor macros for control buffer words in RTP input path */
Can you add a a bit more framing to clearly separate
the 2 groups of cb fields? […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/d304aa5a_7737c70d?usp… :
PS1, Line 39: #define tch_ul_msg_bfi(x) ((x)->cb[0])
I wonder whether this is a boolean, a flag, or an
integer.
New patch includes clarifying comments.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/8082f7f1_20d15c96?usp… :
PS1, Line 2229: teh = 0xE0 | (tch_ul_msg_bfi(msg) << 1);
and this kind of operation together with "I
wonder whether this is a boolean, a flag, or an integer. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8097946429e83eae90f89e49d17ffb8eb0636fcb
Gerrit-Change-Number: 41047
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 19:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>