[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET ...................................................................... asterisk: Implement AMI_Adapter using IPL4 instead of TELNET Change Telnet_PT to a regular TCP socket for the AMI interface. I started using Telnet_PT port since initial use of the interface was done through telnet, but it's not really a telnet interface and stuff starts becoming difficult to maintain properly when events (generated by Asterisk at any time) arrive. The current TEXT decoder/encoder from Titan seems to be struggling in 2 scenarios, so for now we are adding some workarounds in dec_AMI_Msg_ext() before calling it in order to be able to go forward and avoid errors: 1- Fields of format "MyFieldName: \r\n" (empty value). I tried changing the "value" field in record AMI_Field to "optional", but then apparently the TEXT decoder fails to decode values consisting of several words. Ideally, I'd expect the TEXT decoder to put an empty "" string in the "value" field in that case if "optional" is not flagged in the record. 2- Fields of format "MyFieldName: foobar: hey there \r\n" containing a ": " token in the value. I'd expect TEXT decoder to put all subsequent strings in the last field "value" if no more fields are described in the record. Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d --- M asterisk/AMI_Functions.ttcn M asterisk/Asterisk_Tests.cfg M asterisk/Asterisk_Tests.default M asterisk/Asterisk_Tests.ttcn 4 files changed, 211 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/36755/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d Gerrit-Change-Number: 36755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset