[S] Change in osmo-bts[master]: common/Makefile.am: comment out 'libbts_la_LDADD = probes.lo'

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33533 ) Change subject: common/Makefile.am: comment out 'libbts_la_LDADD = probes.lo' ...................................................................... common/Makefile.am: comment out 'libbts_la_LDADD = probes.lo' This line makes no sense and triggers the following warnings: src/common/Makefile.am:83: warning: variable 'libbts_la_LDADD' is defined but no program or src/common/Makefile.am:83: library has 'libbts_la' as canonical name (possible typo) The problem is that there is no 'libbts.la' (libtool archive), but 'libbts.a' (normal archive file). There is no way to attach dependencies to *.a archives, it's only possible for *.la archives. Either each of the BTS variants needs to add this 'probes.lo' to their LDADD list manually, or the 'libbts.a' needs to be converted to a libtool archive 'libbts.la'. For comment out this line. Change-Id: I829c63988fd51b481cb9f13a81dfaf5e78beb1b8 --- M src/common/Makefile.am 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/33533/1 diff --git a/src/common/Makefile.am b/src/common/Makefile.am index 32f644c..0da62bb 100644 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@ -80,5 +80,6 @@ $(LIBTOOL) --mode=compile $(AM_V_lt) --tag=CC env CFLAGS="$(CFLAGS)" $(DTRACE) -C -G -s $< -o $@ BUILT_SOURCES = probes.h probes.lo -libbts_la_LDADD = probes.lo +# FIXME: libbts is not a libtool archive (*.la) +# libbts_la_LIBADD = probes.lo endif -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I829c63988fd51b481cb9f13a81dfaf5e78beb1b8 Gerrit-Change-Number: 33533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: newchange