Attention is currently required from: Sebastian Schmidt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34601?usp=email )
Change subject: Add pyshark to requirements.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
as @dexter stated, we prefer to not have a hard dependency. most pysim users will likely never use pySim-trace, and hence never need that dependency.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34601?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic93e83195feb7ada3b364bae86442dae90d81d90
Gerrit-Change-Number: 34601
Gerrit-PatchSet: 1
Gerrit-Owner: Sebastian Schmidt
yath+osmocom@yath.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: Sebastian Schmidt
yath+osmocom@yath.de
Gerrit-Comment-Date: Tue, 03 Oct 2023 12:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment