Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33201 )
Change subject: stream: Add IPA send function, pull IPA headers in segm. cb
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
I really still fail to see why do we want to have & use a new API which puts together
prepending the IPA headers to msgb and then submitting the msgb to the stream object. If
at all, create a new helper API to prepend both IPA headers in one call, but I'd
really leave aside doing both things (prepending to msg, submitting).
I really don't see the gain of coupling 2 totally unrelated interfaces/layers for the
sake of sparing 1 code line.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33201
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 11
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 10 Jul 2023 08:45:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment