Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32644 )
Change subject: sm: Fix APN IE content not transmitted in Act PDP Ctx Req ......................................................................
Patch Set 1:
(1 comment)
File src/sm/sm_pdu.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32644/comment/54bba76b_dec52cc4 PS1, Line 208: rc = osmo_apn_from_str(msg->tail, msgb_tailroom(msg), sme->apn); : if (rc < 0) : return -EINVAL; : *l = rc; : msgb_put(msg, *l);
IMHO this is highly unusual: passing a pointer to msg->tail and storing some data before doing the […]
I think this istotally fine, since msgb_tailroom(msg) is passed to osmo_apn_from_str, which should return < 0 if there's not enough space.