Attention is currently required from: laforge, fixeria.

View Change

1 comment:

• File src/sm/sm_pdu.c:

  • Patch Set #1, Line 208:

    	rc = osmo_apn_from_str(msg->tail, msgb_tailroom(msg), sme->apn);
    		if (rc < 0)
    			return -EINVAL;
    		*l = rc;
    		msgb_put(msg, *l);
    

    > IMHO this is highly unusual: passing a pointer to msg->tail and storing some data before doing the […]

    I think this istotally fine, since msgb_tailroom(msg) is passed to osmo_apn_from_str, which should return < 0 if there's not enough space.

To view, visit change 32644. To unsubscribe, or for help writing mail filters, visit settings.