Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email )
Change subject: LAPDm: Add support for RTS based polling ......................................................................
Patch Set 9:
(4 comments)
File include/osmocom/gsm/lapdm.h:
https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/550c0b77_938b5c9a PS8, Line 38: uint32_t t200_timeout; /*!< T200 timeout frame number */
also breaks ABI, see my comment regarding TODO-RELEASE in previous patch
Done
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/a994a5b8_fb4e3b8e PS8, Line 355: uint8_t chan_nr, uint8_t link_id, uint8_t pad)
unrelated cosmetic change?
Done
https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/5d9fc761_bc350e9d PS8, Line 1617: void lapdm_entity_set_t200_fn(struct lapdm_entity *le, int *t200_fn)
this misses explanation of what the int t200_fn array is supposed to contain. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/4fe72b97_23274def PS8, Line 1625: T200 FN timer
The reader should be educated what is a "T200 FN timer"? What are the expected argument types? In wh […]
Done