Attention is currently required from: laforge.

View Change

4 comments:

• File include/osmocom/gsm/lapdm.h:

  • Patch Set #8, Line 38: uint32_t t200_timeout; /*!< T200 timeout frame number */

    also breaks ABI, see my comment regarding TODO-RELEASE in previous patch

    Done

• File src/gsm/lapdm.c:

  • Patch Set #8, Line 355: uint8_t chan_nr, uint8_t link_id, uint8_t pad)

    unrelated cosmetic change?

    Done

  • Patch Set #8, Line 1617: void lapdm_entity_set_t200_fn(struct lapdm_entity *le, int *t200_fn)

    this misses explanation of what the int t200_fn array is supposed to contain. […]

    Done

  • Patch Set #8, Line 1625: T200 FN timer

    The reader should be educated what is a "T200 FN timer"? What are the expected argument types? In wh […]

    Done

To view, visit change 34986. To unsubscribe, or for help writing mail filters, visit settings.