Attention is currently required from: pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31071 )
Change subject: netdev: Fix compilation building with --disable-libmnl
......................................................................
Patch Set 1:
(2 comments)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/eebc3667_46954c13
PS1, Line 845:
You could actually have the ifdef here and log/return -ENOTSUP. Then there's no
message about bringing an interface up/down that we know is wrong.
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/9a4c71d3_db4982bd
PS1, Line 855: LOGNETDEV(netdev, LOGL_NOTICE, "%s: NOT SUPPORTED. Build libosmocore
with --enable-libmnl.\n", __func__);
I'm torn whether these should actually abort the program. This should at least be
LOGL_ERROR, though.
Same on the other hunks
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31071
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I62bdea075afb9e0cc2bbcec6dd3a930e8f7bbc40
Gerrit-Change-Number: 31071
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jan 2023 16:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment