[XL] Change in osmo-ttcn3-hacks[master]: smdpp: proper headers for native code

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122?usp=email ) Change subject: smdpp: proper headers for native code ...................................................................... Patch Set 3: (317 comments) File smdpp/helpers.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a7836bc2_af0e… : PS3, Line 56: void operator()(EVP_PKEY* key) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/88925d19_37b6… : PS3, Line 56: void operator()(EVP_PKEY* key) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/72f3250b_d3d8… : PS3, Line 171: #endif // HELPERS_H adding a line without newline at end of file File smdpp/http_client.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e75bc8d7_a8b8… : PS3, Line 21: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6759e5bc_1a68… : PS3, Line 26: std::string body; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e990e808_3271… : PS3, Line 28: std::string headers; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/413053bc_276a… : PS3, Line 33: std::string clientCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/75657654_48ee… : PS3, Line 34: std::string clientKeyPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffa72c6f_2ea7… : PS3, Line 37: std::string contentType = "application/json"; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8c0e87a9_837f… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e72d70e2_f400… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9b2e36aa_805d… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/954d0797_2ea3… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bb3475a2_2a9c… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fbc45b98_9a88… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d4bf1ab1_5fbc… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3288b097_7596… : PS3, Line 41: const PostConfig& config); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/164dff42_5f41… : PS3, Line 43: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ff01acd4_f322… : PS3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8036c54d_4592… : PS3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/53aaa731_e912… : PS3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12de7764_6777… : PS3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/701cb46b_977a… : PS3, Line 48: X509_STORE* store; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c5491b1a_89fa… : PS3, Line 49: std::vector<X509*>* certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2ed257bf_902c… : PS3, Line 49: std::vector<X509*>* certPool; spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/702a7543_355e… : PS3, Line 49: std::vector<X509*>* certPool; space required before that '*' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/cf6b16cc_21af… : PS3, Line 49: std::vector<X509*>* certPool; space prohibited after that '*' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f4375ff7_0f7f… : PS3, Line 49: std::vector<X509*>* certPool; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/203fdfd5_11eb… : PS3, Line 51: std::string errorMessage; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/44e256dd_f6b2… : PS3, Line 54: static std::string get_cn_name(X509_NAME* const name); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/343b87a5_f23e… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f71c79ff_a5aa… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5a23764f_a699… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2feaa6ba_94bd… : PS3, Line 60: #endif // HTTP_CLIENT_H adding a line without newline at end of file File smdpp/logger.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a30c6e4c_0e9f… : PS3, Line 256: #endif // LOGGER_H adding a line without newline at end of file File smdpp/rsp_client.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/06edc4d1_a02c… : PS3, Line 20: typedef struct x509_st X509; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/778c33f7_43d5… : PS3, Line 21: typedef struct evp_pkey_st EVP_PKEY; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/adb0168f_f3f6… : PS3, Line 22: typedef struct x509_store_st X509_STORE; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e6f86d94_2529… : PS3, Line 36: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e2fc2bc5_ab83… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/297be6f8_cd76… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d22d3ad_b92f… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0b337c4b_7fa4… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b17c5d28_5b18… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/93932935_ec2a… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/19613ee7_5fbe… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9ae309a4_b28f… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3fe797f0_c4ce… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6cb87028_14b2… : PS3, Line 53: void setCACertPath(const std::string& path); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c948f6f1_7887… : PS3, Line 54: void loadEUICCCertificate(const std::string& euiccCertPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c56a9ae3_da0d… : PS3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1f63a823_f584… : PS3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/43fd90bd_0688… : PS3, Line 56: void loadEUMCertificate(const std::string& eumCertPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4f252998_dec0… : PS3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2590f5bc_dbc0… : PS3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4587e4cb_f5ae… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/be579b7f_3797… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4715569a_8f4b… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c422853b_98c2… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0224ad71_f0d4… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/834ca507_fa3a… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/64f1c7e7_5752… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/95a592e8_6252… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15ff6f11_bd55… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/da79fe1d_5112… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7f0bb054_a25c… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8923d519_3ba9… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15e24e12_ed90… : PS3, Line 66: void generateEUICCOtpk(); Bad function definition - void generateEUICCOtpk() should probably be void generateEUICCOtpk(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5d33c09e_3933… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4535b7be_9460… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a4cfb107_9350… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3c7d6181_5f76… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ea6c5f38_13bd… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/55f74853_a5dc… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b0863f5c_2fb0… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/372a938c_210c… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0f935a97_c11d… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/76ab45bd_8269… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/36c858cd_3bab… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c2a04e99_dbf8… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/734a1e19_05b4… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0a391efa_eb08… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/90c6f059_841d… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8af3ab1b_2391… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/26603c91_a240… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/13d559cd_1e0a… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a4ffe5dc_c50e… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/027cb963_51b1… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bf66bf18_18c0… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/053c60f4_e2d9… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/93fed03a_a68b… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3fa38635_7e83… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/16b382c5_b450… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a73e6052_3bd7… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/11790386_c69c… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0c2f274d_619d… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/352343d5_4eda… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c9d93102_0722… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9e080112_7f62… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e46b34d5_b434… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e96c5e2_c379… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6869e4b7_c0c9… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2dc606bd_7529… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0747769b_4000… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b3a474e4_cb29… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/635c8ffa_b86f… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bb811f0c_2c04… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7d565577_824a… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6a669a47_7e42… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/009d0b76_8859… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/60614fd7_619f… : PS3, Line 75: void setConfirmationCode(const std::string& confirmationCode); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/88c8a0b4_28fb… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d3c8da77_e3e4… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b10d2a05_b854… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e7dd3982_dc9b… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b18ebdc5_e17e… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a1c81862_c97a… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bed5134_8e00… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f38b9687_34e5… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/05be8fc5_0f05… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1945b33c_29a6… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/289a1fd6_20c0… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fbd7768b_eaea… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2c00a494_d8df… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2987e011_8410… : PS3, Line 81: void configureHttpClient(bool useCustomTlsCert, const std::string& customTlsCertPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/92c5e590_3744… : PS3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9c2806b3_30f5… : PS3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/48683a81_70d9… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e5c834be_ede8… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f94ec7c3_964c… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/41da2d1d_1e98… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e10e779b_4fb3… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1f3e6bb2_42bb… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2a042a6d_df40… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/938aa22e_feeb… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bf904b1_e29e… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/69d24961_c13b… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/210fada4_bc5a… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/283f0814_4d37… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b5f7dd73_a33d… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bdedf00_2614… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3a3488c2_a0a4… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/267cb1e7_4977… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6b2dc5ba_7308… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5693a859_c29b… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", Statements should start on a tabstop Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/18d62ec4_4270… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/decbf24c_d772… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8d35117e_a785… : PS3, Line 91: const std::string& contentType = "application/json"); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/06b70c4b_4690… : PS3, Line 93: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c41f8af2_980d… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/97dbce9d_6922… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8ec219bc_fde3… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ee76880e_2b31… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d4b6acd4_ea06… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d2f2bdc6_ac8a… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/51a39e2b_703d… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d8d6e54_bac5… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d952a3fd_90d6… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1e34158e_e886… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e2a4d91d_9c51… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/27994f24_28e1… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4009f09b_4173… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/25a55cb2_daef… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/be3c4157_6c11… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82ee5fe9_3eb9… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/336e8499_468c… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7f7db813_ff0a… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9c98a44d_525e… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/83aff81c_82a8… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/832c4f3d_3781… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4bf336fe_9f17… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2d811d85_daba… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b5e9de37_49d4… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fdd43d84_16c2… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b1730ab1_474f… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bbb14461_002f… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a701e5ad_35ae… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f6775912_2398… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e6360cd_2e36… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/206c683b_2915… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/46ec6c51_62f6… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ae595a55_8a6d… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6cc6d46a_52df… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d0ec9c25_fc30… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b455158b_266a… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d8ba1f7d_7588… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fe6bbaa1_c42f… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/420473b8_c0bd… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/239936bf_b643… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/af87c7fc_c750… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6d77f78d_6b0c… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1dd6cae0_709d… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffce72c3_6ab2… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f289cc8f_1c52… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/00868cd5_fa74… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/637bdfd7_fb6c… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ed991800_b601… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c8915922_7de3… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5143630e_b445… : PS3, Line 101: const std::string& certSource); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b8ce2e59_0dcf… : PS3, Line 102: int getEUICCCurveNID(); Bad function definition - int getEUICCCurveNID() should probably be int getEUICCCurveNID(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8b4f265c_ff15… : PS3, Line 105: std::string m_serverUrl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bef2b79d_dd1e… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0381be25_61d2… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f161b7e7_7af3… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b03b35a5_7baa… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8379037c_f149… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2d3bbb1e_ae2a… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/dce21a06_522f… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f493e300_2fa2… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/29946b00_c0a4… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4b5627c5_a0c0… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/73039811_b1e1… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e20183d_4f2e… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/81ef86e6_759d… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d4f0bba_13cd… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/57b853ea_a376… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6eb46dc8_547f… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/27b54947_37be… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2347efb_a428… : PS3, Line 113: std::string m_EID; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/77f6f5fb_4a76… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8fded099_aebf… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4bc12274_fd84… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21922396_57ad… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ab9c59bd_1d10… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7c1fd285_1df0… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8f13e1dd_4ee5… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21f9d50a_7d4a… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6403f0ab_856f… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/807a9b46_16c7… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e9bf49e3_5067… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/62f74ed2_ae14… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fc8ed102_54ff… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12700654_69a2… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f564784d_59e9… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/16958c21_f49e… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12cd723e_4de2… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8793ce2b_6744… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b7e3b409_8172… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/20dc5493_5709… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffcb7700_6fdf… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9880fe95_f0b5… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2c947d3_ccd7… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/feda9ee7_255b… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8886cae7_c8d3… : PS3, Line 124: std::string m_confirmationCode; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/005651bd_87a6… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4f2f18c9_4879… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2112298_7cdd… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c6657606_104c… : PS3, Line 126: std::vector<uint8_t> m_transactionId; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/67b2b2e6_34a8… : PS3, Line 126: std::vector<uint8_t> m_transactionId; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/48284d9f_0f83… : PS3, Line 126: std::vector<uint8_t> m_transactionId; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/dce77933_28ac… : PS3, Line 127: std::string m_caCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0971dc94_aab9… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/69a82c17_971e… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/cf705b9f_3e4e… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a0136cd9_4f42… : PS3, Line 131: std::string m_customTlsCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/77f10ac2_6d6f… : PS3, Line 134: std::string m_clientCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/62e20b76_d467… : PS3, Line 135: std::string m_clientKeyPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/352e160d_18d3… : PS3, Line 140: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/92377444_341f… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7fed68bd_3903… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e96116bd_3cf2… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fed40fd5_dfd2… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bac6f28d_a257… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f6f9f06e_eda1… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f17e0efc_9321… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/080f8d16_530f… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/eaa72a8b_4529… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7fba611b_4241… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/32e40d10_a795… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/826ee265_2ec4… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/604fe729_b9fd… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/80408ae7_d016… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ae5513bf_ace2… : PS3, Line 144: const std::vector<std::string>& name_filters); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/85681c6c_7a5e… : PS3, Line 144: const std::vector<std::string>& name_filters); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/19dd4ae7_b5e8… : PS3, Line 144: const std::vector<std::string>& name_filters); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82c20e06_e1da… : PS3, Line 144: const std::vector<std::string>& name_filters); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/02c05a69_ef42… : PS3, Line 145: static std::string getEID(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a60ca77b_ff0d… : PS3, Line 146: static std::string getSubjectName(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a8ef8372_e35b… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/52dfc6d6_59b1… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/39d656c8_e7a1… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0338591f_d0fa… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/17e8a06b_8a6f… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21194dbf_e05b… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/445edac0_f9f2… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4a1b865f_fa84… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b3b3b04c_c7a6… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/754812b7_89fc… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f549d921_ef9a… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15b7a321_6522… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e9e89843_473d… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/81202730_99e2… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/913fd2d7_1856… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a6cd8158_ac0a… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/98e9284c_6349… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8674dd6d_8393… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ed8cda0b_1f72… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6ee32e92_268b… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0fad15c8_941e… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9200d119_fdcc… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82f9fcc7_abc7… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bcfda601_0487… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b62b2078_9bc8… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/af8752c9_6867… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c51ca2d0_6dd5… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/32f24db8_562c… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d120efb3_5d1f… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/983a35f1_39cc… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9a165419_cbcf… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/87ab5b3b_7b5d… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/571b44a7_965e… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c9ae3b5a_1cca… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ef11eec8_f386… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ce069735_1dc9… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/543e6ebe_3bd9… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/26b8bd45_f55f… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7caa9079_a1ac… : PS3, Line 159: #endif // RSP_CLIENT_H adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9dcb3249fc712e2ddb2c7cf48d4fc54425848bc6 Gerrit-Change-Number: 41122 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 17 Sep 2025 13:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No