Attention is currently required from: Hoernchen.
317 comments:
File smdpp/helpers.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 56: void operator()(EVP_PKEY* key) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 56: void operator()(EVP_PKEY* key) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: #endif // HELPERS_H
adding a line without newline at end of file
File smdpp/http_client.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 21: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 26: std::string body;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 28: std::string headers;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 33: std::string clientCertPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 34: std::string clientKeyPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 37: std::string contentType = "application/json";
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
spaces required around that '>' (ctx:OxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 41: const PostConfig& config);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 43: private:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 48: X509_STORE* store;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 49: std::vector<X509*>* certPool;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 49: std::vector<X509*>* certPool;
spaces required around that '>' (ctx:OxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 49: std::vector<X509*>* certPool;
space required before that '*' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 49: std::vector<X509*>* certPool;
space prohibited after that '*' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 49: std::vector<X509*>* certPool;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 51: std::string errorMessage;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 54: static std::string get_cn_name(X509_NAME* const name);
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg);
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg);
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 60: #endif // HTTP_CLIENT_H
adding a line without newline at end of file
File smdpp/logger.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 256: #endif // LOGGER_H
adding a line without newline at end of file
File smdpp/rsp_client.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 20: typedef struct x509_st X509;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 21: typedef struct evp_pkey_st EVP_PKEY;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 22: typedef struct x509_store_st X509_STORE;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 36: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: const std::vector<std::string>& name_filters = {});
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: const std::vector<std::string>& name_filters = {});
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: const std::vector<std::string>& name_filters = {});
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: const std::vector<std::string>& name_filters = {});
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 53: void setCACertPath(const std::string& path);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 54: void loadEUICCCertificate(const std::string& euiccCertPath);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = "");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = "");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 56: void loadEUMCertificate(const std::string& eumCertPath);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = "");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = "");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 60: std::vector<uint8_t> getEUMCertificate();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 60: std::vector<uint8_t> getEUMCertificate();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 60: std::vector<uint8_t> getEUMCertificate();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: std::vector<uint8_t> getEUICCCertificate();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: std::vector<uint8_t> getEUICCCertificate();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: std::vector<uint8_t> getEUICCCertificate();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 62: std::vector<uint8_t> getCICertificate();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 62: std::vector<uint8_t> getCICertificate();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 62: std::vector<uint8_t> getCICertificate();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 65: std::vector<uint8_t> generateChallenge();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 65: std::vector<uint8_t> generateChallenge();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 65: std::vector<uint8_t> generateChallenge();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 66: void generateEUICCOtpk();
Bad function definition - void generateEUICCOtpk() should probably be void generateEUICCOtpk(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 67: std::vector<uint8_t> getEUICCOtpk();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 67: std::vector<uint8_t> getEUICCOtpk();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 67: std::vector<uint8_t> getEUICCOtpk();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 71: const std::vector<uint8_t>& derDataServerCert);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 71: const std::vector<uint8_t>& derDataServerCert);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 71: const std::vector<uint8_t>& derDataServerCert);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 71: const std::vector<uint8_t>& derDataServerCert);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 75: void setConfirmationCode(const std::string& confirmationCode);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 81: void configureHttpClient(bool useCustomTlsCert, const std::string& customTlsCertPath = "");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode,
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride,
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "",
Statements should start on a tabstop
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "",
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "",
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 91: const std::string& contentType = "application/json");
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 93: private:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 101: const std::string& certSource);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 102: int getEUICCCurveNID();
Bad function definition - int getEUICCCurveNID() should probably be int getEUICCCurveNID(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 105: std::string m_serverUrl;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA;
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool;
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 112: std::vector<uint8_t> m_euiccSKI;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 112: std::vector<uint8_t> m_euiccSKI;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 112: std::vector<uint8_t> m_euiccSKI;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 113: std::string m_EID;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: std::vector<uint8_t> m_euiccOtpk;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: std::vector<uint8_t> m_euiccOtpk;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: std::vector<uint8_t> m_euiccOtpk;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 122: std::vector<uint8_t> m_eumPublicKeyData;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 122: std::vector<uint8_t> m_eumPublicKeyData;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 122: std::vector<uint8_t> m_eumPublicKeyData;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 124: std::string m_confirmationCode;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> m_confirmationCodeHash;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> m_confirmationCodeHash;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> m_confirmationCodeHash;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 126: std::vector<uint8_t> m_transactionId;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 126: std::vector<uint8_t> m_transactionId;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 126: std::vector<uint8_t> m_transactionId;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 127: std::string m_caCertPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 129: std::unique_ptr<HttpClient> m_httpClient;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 129: std::unique_ptr<HttpClient> m_httpClient;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 129: std::unique_ptr<HttpClient> m_httpClient;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 131: std::string m_customTlsCertPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 134: std::string m_clientCertPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 135: std::string m_clientKeyPath;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 140: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename);
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory,
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory,
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: const std::vector<std::string>& name_filters);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: const std::vector<std::string>& name_filters);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: const std::vector<std::string>& name_filters);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: const std::vector<std::string>& name_filters);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 145: static std::string getEID(X509* cert);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 146: static std::string getSubjectName(X509* cert);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
spaces required around that '>' (ctx:OxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 159: #endif // RSP_CLIENT_H
adding a line without newline at end of file
To view, visit change 41122. To unsubscribe, or for help writing mail filters, visit settings.