Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33347
)
Change subject: Add support for encoding/decoding SMS in TPDU and SMPP format
......................................................................
Patch Set 1:
(2 comments)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/pysim/+/33347/comment/5d4b969b_312879de
PS1, Line 25: pip install
git+https://github.com/hologram-io/smpp.pdu
Is this really needed given that you adding this dep to `requirements.txt`?
File ota_test.py:
https://gerrit.osmocom.org/c/pysim/+/33347/comment/8ab8e82e_5143a312
PS1, Line 1: #!/usr
`/usr/bin/env python3` please
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33347
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0d95e62c1e7183a7851d1fe38df0f5133830cb1f
Gerrit-Change-Number: 33347
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 17 Jun 2023 11:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment