Attention is currently required from: jolly, manawyrm, tnt.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email )
Change subject: Add option to automatically reset RIFO on underrun/overflow ......................................................................
Patch Set 4:
(3 comments)
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/2351b618_56ab8cc3 PS4, Line 278: int32_t d = fn32+i - iline->e1t.rifo.next_out_fn; missing space between "fn32+i". Are you accounting for wraparound in here? doesn't look like.
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/b71a5f0d_3313678c PS4, Line 279: iline->e1t.delay += d; do you account for overflow/wrapround here?
File src/octoi/frame_rifo.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/32bcb9c3_f705c6fd PS4, Line 111: { wrong place for "{" char.