Attention is currently required from: jolly, manawyrm, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email ) Change subject: Add option to automatically reset RIFO on underrun/overflow ...................................................................... Patch Set 4: (3 comments) File src/octoi/e1oip.c: https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/2351b618_56ab8cc3 PS4, Line 278: int32_t d = fn32+i - iline->e1t.rifo.next_out_fn; missing space between "fn32+i". Are you accounting for wraparound in here? doesn't look like. https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/b71a5f0d_3313678c PS4, Line 279: iline->e1t.delay += d; do you account for overflow/wrapround here? File src/octoi/frame_rifo.c: https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/32bcb9c3_f705c6fd PS4, Line 111: { wrong place for "{" char. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748 Gerrit-Change-Number: 34554 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account@tbspace.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: manawyrm <osmocom.account@tbspace.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 09:48:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment