Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )
Change subject: FR/HR/EFR: centralize TCH UL SID classification ......................................................................
Patch Set 2:
(2 comments)
File include/osmo-bts/msg_utils.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/ecd67c4d_79103d3c?usp=... : PS1, Line 25: * Additionally for HRv1 codec, we use a control buffer word to pass
IMHO once you improve de comment framing (see first patch); this show go immediatelly above each fie […]
Done
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/345dd303_290c4afd?usp=... : PS1, Line 2349: tch_ul_msg_sid(msg) = sidc;
I wonder whether this msg field should be called "hr_sid" instead of "sid".
Done