Attention is currently required from: daniel, laforge, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email )
Change subject: client: Support generation of pcapng file format
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File include/osmo-pcap/osmo_pcap_file.h:
https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/f1e7c62d_b3620d38?us… :
PS8, Line 87: /* uint32_t block_total_length */
Nope, it's fine, the field is duplicated at the
end of block_body so that the file can be navigated […]
ah nice
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I3c80518a1e53a1f77e1aca8dfa83f683f9516ad6
Gerrit-Change-Number: 39265
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Jan 2025 16:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>