Attention is currently required from: Hoernchen.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/33945 )
Change subject: ms/va: add test tool and data
......................................................................
Patch Set 6:
(1 comment)
File utils/va-test/burst-gen.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/ea144aca_f41f59a7
PS3, Line 21:
Done
please also put that in a comment in the
actual source code file so that the reader doesn't have to check the commitlog. Just
the one line before or after the copyright/license is sufficient.
Plus, the git commit log needs line wrapping. It's customary to not exceed 80
characters, and git should actually warn/complain about it when you attempt to exceed it?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/33945
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ie38ed4996134e84ad0481872a743299bb442b3db
Gerrit-Change-Number: 33945
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 10:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment