20 Feb
2023
20 Feb
'23
11:40 a.m.
Attention is currently required from: neels, laforge, fixeria, msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Update multiaddr helper
......................................................................
Patch Set 16: Code-Review-1
(3 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/668177da_4b64655d
PS16, Line 216: size_t count = use_hosts ? host_count : addrs_count;
what? why do you reuse the same function with 2 sets of different parameters? this is
utterly confusing. Have 2 functions with different parameter set instead.
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/ed0b0257_75b5e3f2
PS16, Line 263: static void multiaddr_log_helper(uint8_t loglevel, const char *fmt,
uint16_t port, const char **hosts, size_t host_cnt)
I see no point in having this helper, with a formatting string which then anyway implies a
given order of parameters. Simply use the 3 lines this function has.
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/1e5b48a8_cb793df0
PS16, Line 831: multiaddr_log_helper(LOGL_ERROR, "cannot setsockopt socket: %s:%u:
%s\n",
This looks really weird, you are passing a formatted string with parameters which are not
matching the format...
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 16
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:40:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment