Attention is currently required from: neels, laforge, fixeria, msuraev.

Patch set 16:Code-Review -1

View Change

3 comments:

• File src/core/socket.c:

  • Patch Set #16, Line 216: size_t count = use_hosts ? host_count : addrs_count;

    what? why do you reuse the same function with 2 sets of different parameters? this is utterly confusing. Have 2 functions with different parameter set instead.

  • Patch Set #16, Line 263: static void multiaddr_log_helper(uint8_t loglevel, const char *fmt, uint16_t port, const char **hosts, size_t host_cnt)

    I see no point in having this helper, with a formatting string which then anyway implies a given order of parameters. Simply use the 3 lines this function has.

  • Patch Set #16, Line 831: multiaddr_log_helper(LOGL_ERROR, "cannot setsockopt socket: %s:%u: %s\n",

    This looks really weird, you are passing a formatted string with parameters which are not matching the format...

To view, visit change 28993. To unsubscribe, or for help writing mail filters, visit settings.