Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38309?usp=email )
Change subject: s1gw: use the new counter name (out_pkt.forward.unmodified)
......................................................................
Patch Set 1:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38309/comment/df793454_a97b…
:
PS1, Line 206: {name := mp_statsd_prefix &
"ctr.s1ap.proxy.out_pkt.forward.unmodified.value", mtype := "c", min
:= 2, max := 2}
this change of name looks weird to me tbh. The idea is that in_pkt contains subsections
based on decisions taken to it. So "I got an input packet and decided to forward
it". Not sure why you wanted to change the name now..
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38309?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I037fea187bb78ba0d4b82d30915c5270d4cd28bb
Gerrit-Change-Number: 38309
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 27 Sep 2024 11:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No