Attention is currently required from: osmith, neels, fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 )
Change subject: GSMTAP: allow configuring src IP for log messages
......................................................................
Patch Set 13:
(1 comment)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/7996a975_08dc03f7
PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src);
I've manually checked and I've also submitted the changes to facilitate this check as a separate pat […]
Fine if you checked manually then.
"No idea what's wrong with the grep command you've posted" well, this code here relates to logging through gsmtap, and the test you modified in the next patch seems to be doing nothing with gsmtap logging?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 13
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Mar 2023 16:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment
