Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34169 )
Change subject: Added crypto support ......................................................................
Patch Set 1:
(5 comments)
File src/crypto/hurdle.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10588): https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/caf79c6b_91d85cc7 PS1, Line 106: for (int i = 0; i < 256; i++) { braces {} are not necessary for single statement blocks
File src/crypto/taa1.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10588): https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/c171fc75_a036ecc1 PS1, Line 403: */ trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10588): https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/cbfbf66b_7f699118 PS1, Line 437: Computes: trailing whitespace
File src/crypto/tetra_crypto.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10588): https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/d92680cc_f3c6d0ba PS1, Line 249: // key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time), tmpdu_offset, ct_len); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10588): https://gerrit.osmocom.org/c/osmo-tetra/+/34169/comment/bbbfa6c8_4653a9a2 PS1, Line 280: // key->addr, key->index, tcs->hn, tetra_tdma_time_dump(tdma_time)); please, no space before tabs