8 Nov
2024
8 Nov
'24
5:24 p.m.
Attention is currently required from: JPM, dexter, laforge.
fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS1:
I meant this should be mentioned in the code, in a comment.
Done
File src/osmocom/construct.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/385bf24e_345e4... : PS1, Line 265: """convert a bytes(3) type to BCD string like 262-02 or 262-002."""
Let's add spec. reference here? 3GPP TS 24. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
Gerrit-Change-Number: 38687
Gerrit-PatchSet: 3
Gerrit-Owner: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 08 Nov 2024 16:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de