Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 )
Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10740): https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/468f03f6_169eeea6 PS4, Line 557: } else { else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10740): https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/754d1c9b_f1d5107a PS4, Line 558: if (pcu_rx_rr_paging_pch(bts, pag_grp, pch)) code indent should use tabs where possible