Attention is currently required from: daniel, pespin.
Hello Jenkins Builder, daniel,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/41914?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder
Change subject: osmo_io: Propagate segment_cb errors to the read_cb ......................................................................
osmo_io: Propagate segment_cb errors to the read_cb
Previous logic was to drop an entire msgb in the stream and pretend it can continue working that way, which clearly makes no sense. Instead, if segment_cb detects some problem (eg. buggy peer sending corrupted data according to protocol), propagate the issue through read_cb() so that the app can act on it, ie. most likely close the connection.
Related: SYS#7842 Change-Id: I572e68df6799b903507229a9beee6fa7d7d6d652 --- M src/core/osmo_io.c M tests/osmo_io/osmo_io_test.c M tests/osmo_io/osmo_io_test.err M tests/osmo_io/osmo_io_test.ok 4 files changed, 117 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/41914/5