[XS] Change in osmo-hnbgw[pespin/rel-1.5.0]: drop config.vty tests from make check

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38710?usp=email ) Change subject: drop config.vty tests from make check ...................................................................... drop config.vty tests from make check The intention of those tests was to test various osmo-hnbgw startup scenarios. It seemed the fastest/simplest way to do it at the time, but the output depends on another library, regularly causing test fallout. Keep the tests around for reference. They can still be invoked manually with 'make config-tests'. Related: OS#6380 Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b (cherry picked from commit 4468d8728e07d9e74a8b08d8bf2d903cc4c5bbfc) --- M tests/Makefile.am 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/10/38710/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d499c33..f890614 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -41,7 +41,6 @@ if ENABLE_EXT_TESTS python-tests: $(MAKE) vty-test - $(MAKE) config-tests osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else @@ -63,6 +62,11 @@ $(U) $(srcdir)/$(VTY_TEST) # Test each config/*.cfg file with the corresponding config/*.vty transcript test. +# +# To be invoked manually only: This is not part of 'make check' because the +# output may change when libosmo-sccp changes its VTY appearance, which can +# cause annoying test fallout. +# # Each config test runs an osmo-hnbgw process to talk to, so they must not run concurrently. # To prevent 'make -j N' from running these tests in parallel, call a script with a linear for-loop. .PHONY: config-tests -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38710?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: pespin/rel-1.5.0 Gerrit-Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b Gerrit-Change-Number: 38710 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>