fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42376?usp=email )
Change subject: global_platform: fix s/GET/STORE/ DATA in docs ......................................................................
global_platform: fix s/GET/STORE/ DATA in docs
Both `do_store_data` and `store_data` have identical docstrings that incorrectly describe the command as GET DATA. Should be "STORE DATA". Take a chance to fix missing space between `v2.3` and `Section`.
Change-Id: I33fc80ab8ca50fadc38217b0005eec6169c8e34e --- M pySim/global_platform/__init__.py 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/42376/1
diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index a836134..22554c6 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -562,14 +562,14 @@
@cmd2.with_argparser(store_data_parser) def do_store_data(self, opts): - """Perform the GlobalPlatform GET DATA command in order to store some card-specific data. - See GlobalPlatform CardSpecification v2.3Section 11.11 for details.""" + """Perform the GlobalPlatform STORE DATA command in order to store some card-specific data. + See GlobalPlatform CardSpecification v2.3 Section 11.11 for details.""" response_permitted = opts.response == 'may_be_returned' self.store_data(h2b(opts.DATA), opts.data_structure, opts.encryption, response_permitted)
def store_data(self, data: bytes, structure:str = 'none', encryption:str = 'none', response_permitted: bool = False) -> bytes: - """Perform the GlobalPlatform GET DATA command in order to store some card-specific data. - See GlobalPlatform CardSpecification v2.3Section 11.11 for details.""" + """Perform the GlobalPlatform STORE DATA command in order to store some card-specific data. + See GlobalPlatform CardSpecification v2.3 Section 11.11 for details.""" max_cmd_len = self._cmd.lchan.scc.max_cmd_len # Table 11-89 of GP Card Specification v2.3 remainder = data