Attention is currently required from: arehbein, daniel, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email )
Change subject: logging_gsmtap: Temporarily disable logging when sending the logs ......................................................................
Patch Set 2:
(1 comment)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/34966/comment/2ef9061c_b6b37246 PS2, Line 118: level = target->loglevel I believe we should not be overwriting the input parameters for the sake of saving one variable. If someone later adds some code below, they may need the original value passed by the caller, and it may not be obvious to them that it was overwritten. All in all, please add a new `unsigned int` variable for temporary storage of the `target->loglevel`.