Attention is currently required from: arehbein, daniel, laforge.

View Change

1 comment:

• File src/core/logging_gsmtap.c:

  • Patch Set #2, Line 118: level = target->loglevel

    I believe we should not be overwriting the input parameters for the sake of saving one variable. If someone later adds some code below, they may need the original value passed by the caller, and it may not be obvious to them that it was overwritten. All in all, please add a new `unsigned int` variable for temporary storage of the `target->loglevel`.

To view, visit change 34966. To unsubscribe, or for help writing mail filters, visit settings.