Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email )
Change subject: Add templates for S1AP Handover procedure
......................................................................
Patch Set 2:
(5 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/50ff79ed_2e9e…
:
PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation,
Are you sure this ID is correct?
Yes, this ID in
conjunction with initiating meassage defines the message type. Wireshark trace confirms
this.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/fde8dc55_1c1a…
:
PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation,
Are you sure this ID is correct?
Yes, dito.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/ab2cc1f3_37b3…
:
PS1, Line 2370: }
Optional IEs can be added later whenever they're
needed. […]
I agree.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e8e74a4c_8599…
:
PS1, Line 2391: template (omit) TransportLayerAddress dl_tla,
we usually set default value to ":= omit"
for "template (omit)".
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/37cef340_c0e2…
:
PS1, Line 2638: *,
I see no optional IEs between the `E-RABs To Be Setup
List` and `Source to Target […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6
Gerrit-Change-Number: 41008
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Sep 2025 13:36:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>